Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing files in CTAN zip created by l3build ctan #1302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing files in CTAN zip created by l3build ctan #1302

wants to merge 1 commit into from

Conversation

muzimuzhi
Copy link
Member

@muzimuzhi muzimuzhi commented Jan 5, 2024 •
edited
Loading

Motivation for this change

This PR adds back ./source directory and missing files including licenses and more under ./doc to CTAN zip.

Therefor it makes the content and structure of CTAN zip almost the same as that in pgf_3.1.9.tds.zip, generated by generate_CTANzip() defined in build.lua, with a flattened doc directory structure.

I will show the specific changes perhaps in the form of git diff on tree <dirname> outputs to show what's really changed.

Fixes #1240

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

@muzimuzhi muzimuzhi changed the title Fix/ctan zip Fix missing files in CTAN zip created by l3build ctan Jan 5, 2024
hmenke
hmenke reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@hmenke hmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how much sense it makes to ship the source directory in TeX Live. No compiler is going to look in TeX Live for these files and in the highly unlikely case that anyone actually want to use these files, they can also download them from GitHub.

@muzimuzhi
Copy link
Member Author

muzimuzhi commented Jan 5, 2024 •
edited
Loading

... in the highly unlikely case that anyone actually want to use these files, they can also download them from GitHub.

I never used such utility.

If the decision is to drop source directory, then we might want to add some words in sec. 37 "Writing Graph Drawing Algorithms in C" to point users to ./source/generic/pgf/c directory in GitHub repo.

Interesting all Makefiles in source were not packed into zip by generate_CTANzip(), so I guess the source directory shipped to TeX Live had been incomplete for years.

pgf/build.lua

Lines 323 to 326 in b561e46

-- Source files
elseif string.match(f, "^source/.*$") and basename ~= "Makefile" then
lfs.copy(f, tmppgf .. "source/" .. basename)

@muzimuzhi
Copy link
Member Author

Interesting all Makefiles in source were not packed into zip by generate_CTANzip(), so I guess the source directory shipped to TeX Live had been incomplete for years.

I was wrong. The Makefiles under source were zipped.

@muzimuzhi
Copy link
Member Author

The current status of this PR includes only ./doc files in CTAN zip, no ./source files.

I'd like to check whether the Makefiles in ./source/generic/pgf/c work as expected when installed in some <tds tree>/source, but didn't find the time/interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmenke hmenke hmenke left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some dirs and files are not packed by l3build ctan
2 participants
@muzimuzhi @hmenke